Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Revert "Remove //tools." - #786

Closed
zanderso wants to merge 1 commit into
masterfrom
revert-784-rm_tools
Closed

Revert "Remove //tools."#786
zanderso wants to merge 1 commit into
masterfrom
revert-784-rm_tools

Conversation

@zanderso

Copy link
Copy Markdown
Contributor

Reverts #784

Reverting to unblock the Dart -> Engine autoroller. (A partial revert that restores tools/dart/create_updated_flutter_deps.py would also work.)

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde

Copy link
Copy Markdown
Contributor

A partial revert that restores tools/dart/create_updated_flutter_deps.py would also work.

Can the autoroller be patched instead to move the script into its sources? Or does the script need to be in the engine. Its rough not being able to test a free floating script.

@zanderso

Copy link
Copy Markdown
Contributor Author

Can the autoroller be patched instead to move the script into its sources? Or does the script need to be in the engine. Its rough not being able to test a free floating script.

Not easily. I believe it would need to be ported to go and live in g3.

@chinmaygarde

Copy link
Copy Markdown
Contributor

I am going to create a partial revert instead.

@chinmaygarde chinmaygarde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial revert.

@zanderso zanderso closed this Oct 18, 2023
@zanderso
zanderso deleted the revert-784-rm_tools branch October 18, 2023 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants