-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pay plugin #4
Merged
Merged
Pay plugin #4
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
49103f7
sync android
jonasbark d2b7d7b
POC: add createPaymentMethodFromGooglePay method for Android integration
jonasbark bd38c49
Rename .java to .kt
jonasbark 6094df8
check intent in activity results
jonasbark 8609353
use untyped data for now
jonasbark a4680ac
revert createPaymentMethodFromGooglePay
jonasbark 905d035
Merge remote-tracking branch 'origin/main' into pay_plugin
jonasbark a8d0313
- fix card input + payment methods
jonasbark 6757363
fix missing files
jonasbark 5585462
Merge remote-tracking branch 'origin/main' into pay_plugin
jonasbark 13065c5
card with token, iOS impl
jonasbark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 0 additions & 13 deletions
13
..._android/android/src/main/kotlin/com/facebook/react/bridge/BaseActivityEventListener.java
This file was deleted.
Oops, something went wrong.
11 changes: 11 additions & 0 deletions
11
...pe_android/android/src/main/kotlin/com/facebook/react/bridge/BaseActivityEventListener.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.facebook.react.bridge | ||
|
||
import android.content.Intent | ||
import com.stripe.android.Stripe | ||
import io.flutter.plugin.common.PluginRegistry.ActivityResultListener | ||
|
||
abstract class BaseActivityEventListener : ActivityEventListener, ActivityResultListener { | ||
override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?): Boolean { | ||
return onActivityResult(null, requestCode, resultCode, data) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to do `PaymentMethodCreateParams.Card.create(card.getString("token")!!) otherwise Android would throw a type mismatch error. Did you not get that build error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, compiled and worked fine on the device for me with Android Studio 4.1.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The React Native project also? Looks like it might be related to RN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know it was marked nullable on React Native - my bad
Can you quickly fix it? Otherwise I'll send a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yah, no worries, already done before merging: stripe/stripe-react-native@407fd89
Just wanted to flag with you in case it applied here also.