throw StripeError in case handling paymentintent fails #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #16 |
jonasbark
reviewed
Apr 18, 2021
| }); | ||
| return PaymentIntent.fromJson(result.unfoldToNonNull()); | ||
| } on Exception catch (_) { | ||
| throw StripeError<PaymentIntentError>( |
There was a problem hiding this comment.
that way any kind of useful exception information is getting lost I fear
There was a problem hiding this comment.
Thing is there is no useful exception thrown because everytime stripe throws: promise.reject(RetrievePaymentIntentErrorType.Unknown.toString(), "Retrieving payment intent failed"). I thought at least by this we can make custom error later
|
I don't think any action here is necessary for #16 as the exception is already thrown as you've mentioned. I just had the misconception that paymentIntentError would be part of the data model that is returned by the native part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonasbark would be great if you can check if this is what you want. I also added proper serialisation for the stripe error