-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1350 valueTransformer transform values to null #1423
fix: #1350 valueTransformer transform values to null #1423
Conversation
…hat valueTransformer can transform values to null.
HI @BrottarBasse please resolve pipeline errors (format |
Since my fix contains changes to form_builder_field.dart the checks fail. |
Use the command |
…hat valueTransformer can transform values to null.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
==========================================
- Coverage 87.90% 87.82% -0.09%
==========================================
Files 21 21
Lines 769 772 +3
==========================================
+ Hits 676 678 +2
- Misses 93 94 +1 ☔ View full report in Codecov by Sentry. |
70968df
into
flutter-form-builder-ecosystem:main
Fix for issue 1350 with some changes to tests. This fix makes it so that valueTransformer can transform values to null.
Connection with issue(s)
Close #1350
Connected to #???
Solution description
Changes to implementation of value transformer so that it is still used if value is transformed to null.
I also found that the tests also had flipped values in the expect functions (actual and matcher was wrong way around)
Screenshots or Videos
To Do