Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve focus fields on validation #1254

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented May 18, 2023

Connection with issue(s)

Close #1230

Solution description

  • Remove force validation on autovalidation enables modes
  • Only focus on invalid field when no focus in another field
  • Only focus on invalid field when focusOnInvalid is true

Screenshots or Videos

Screen.Recording.2023-05-18.at.10.18.18.mov
Screen.Recording.2023-05-18.at.10.18.53.mov

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1254 (8cfd21a) into main (ab3b8f7) will decrease coverage by 0.29%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
- Coverage   85.14%   84.86%   -0.29%     
==========================================
  Files          20       20              
  Lines         707      707              
==========================================
- Hits          602      600       -2     
- Misses        105      107       +2     
Impacted Files Coverage Δ
lib/src/form_builder_field.dart 81.91% <80.00%> (ø)
lib/src/form_builder.dart 75.55% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit edcebe5 into main Jun 15, 2023
@deandreamatias deandreamatias deleted the fix-1230-improve-focus-validation branch June 15, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

focusOnInvalid - Validate on invalid bug
1 participant