Support to configure the cache size of vineyard fuse #3982
Conversation
|
Hi @dashanji. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dashanji
force-pushed
the
configure-vineyard-fuse-cache
branch
from
b83b511
to
b98cf27
Compare
| @@ -76,6 +76,8 @@ spec: | |||
| value: {{ .Values.fuse.targetPath }}/rpc-conf | |||
| - name: PRESTOP_MARKER | |||
| value: /tmp/prestop-marker | |||
| - name: CACHE_SIZE | |||
There was a problem hiding this comment.
How about using
{{- if .Values.fuse.options.cacheSize }}
- name: CACHE_SIZE
value: "{{ .Values.fuse.options.cacheSize }}"
{{- end }}There was a problem hiding this comment.
I used a range to avoid specifying each argument one by one.
| // options: | ||
| // cache-size: "0" | ||
| // +optional | ||
| Options map[string]string `json:"options,omitempty"` |
There was a problem hiding this comment.
How to handle other options? I think they are the parts of command and args.
There was a problem hiding this comment.
Thanks for the advice. I have used a range to iterate all fuse options.
| // options: | ||
| // cache-size: "0" | ||
| // +optional | ||
| Options map[string]string `json:"options,omitempty"` | ||
| } |
There was a problem hiding this comment.
I also believe that the name VineyardClientSocketSpec would be more appropriate.
dashanji
force-pushed
the
configure-vineyard-fuse-cache
branch
3 times, most recently
from
143e40d
to
b45eb4b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3982 +/- ##
==========================================
+ Coverage 64.33% 64.35% +0.02%
==========================================
Files 477 477
Lines 28444 28456 +12
==========================================
+ Hits 18300 18314 +14
+ Misses 7968 7967 -1
+ Partials 2176 2175 -1 ☔ View full report in Codecov by Sentry. |
|
@TrafalgarZZZ Please also take a look. Thanks. |
Signed-off-by: Ye Cao <[email protected]>
dashanji
force-pushed
the
configure-vineyard-fuse-cache
branch
from
b45eb4b
to
1e31e3b
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Part of #3749