Support pipe command #3692
Support pipe command #3692
Conversation
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3692 +/- ##
==========================================
+ Coverage 64.46% 64.48% +0.01%
==========================================
Files 471 472 +1
Lines 28153 28239 +86
==========================================
+ Hits 18149 18209 +60
- Misses 7848 7871 +23
- Partials 2156 2159 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
|
|
/test fluid-e2e |
| } | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add a new empty line.
| @@ -132,7 +132,11 @@ func GetChartVersion(chart string) (version string, err error) { | |||
| "|", "grep", "version:"} | |||
| log.V(1).Info("Exec bash -c", "args", args) | |||
|
|
|||
| cmd := exec.Command("bash", "-c", strings.Join(args, " ")) | |||
| // cmd := exec.Command("bash", "-c", strings.Join(args, " ")) | |||
| cmd, err := utils.PipeCommand("bash", "-c", strings.Join(args, " ")) | |||
There was a problem hiding this comment.
It seems that this is unnecessary to use pipe. We can use ddc-helm inspect chart <chart> and scan the returned string. I would like to change this in a next PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TrafalgarZZZ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews