Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CacheFSRuntime CRD definitions and controller implementations #3675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eryugey
Copy link

@eryugey eryugey commented Dec 31, 2023

Cachefs is a distributed filesystem that cache & accelerate any given POSIX directory with distributed cache.

And ThinRuntime was implemented to make general storage like oss/nas easier to integrate with fluid, but thinruntime doesn't have the ability to cache & accelerate data access on thinruntime.

So CacheFSRuntime is add as a general way to accelerate any storage from thinruntime or any given dir.

Fixes: #3674

Copy link

fluid-e2e-bot bot commented Dec 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

fluid-e2e-bot bot commented Dec 31, 2023

Hi @eryugey. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheyang
Copy link
Collaborator

cheyang commented Jan 1, 2024

Cachefs is a distributed filesystem that cache & accelerate any given POSIX directory with distributed cache.

And ThinRuntime was implemented to make general storage like oss/nas easier to integrate with fluid, but thinruntime doesn't have the ability to cache & accelerate data access on thinruntime.

So CacheFSRuntime is add as a general way to accelerate any storage from thinruntime or any given dir.

Fixes: #3674

Thank you for your contribution. Can you separate this PR into several small ones? You can follow the vineyard way. #3528

@eryugey
Copy link
Author

eryugey commented Jan 3, 2024

Cachefs is a distributed filesystem that cache & accelerate any given POSIX directory with distributed cache.
And ThinRuntime was implemented to make general storage like oss/nas easier to integrate with fluid, but thinruntime doesn't have the ability to cache & accelerate data access on thinruntime.
So CacheFSRuntime is add as a general way to accelerate any storage from thinruntime or any given dir.
Fixes: #3674

Thank you for your contribution. Can you separate this PR into several small ones? You can follow the vineyard way. #3528

Sure, will do.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (877c607) 64.46% compared to head (9fc1f16) 64.39%.
Report is 18 commits behind head on master.

❗ Current head 9fc1f16 differs from pull request most recent head c638905. Consider uploading reports for the commit c638905 to get more accurate results

Files Patch % Lines
api/v1alpha1/cachefsruntime_types.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3675      +/-   ##
==========================================
- Coverage   64.46%   64.39%   -0.07%     
==========================================
  Files         471      445      -26     
  Lines       28153    26803    -1350     
==========================================
- Hits        18149    17260     -889     
+ Misses       7848     7528     -320     
+ Partials     2156     2015     -141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eryugey eryugey force-pushed the cachefs branch 2 times, most recently from 24e4616 to d0bc47a Compare January 15, 2024 09:42
@eryugey eryugey requested a review from cheyang January 15, 2024 10:00
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

14 New issues
0 Security Hotspots
No data about Coverage
14.1% Duplication on New Code

See analysis details on SonarCloud

@eryugey eryugey requested a review from cheyang January 18, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURES] Add cache runtime for cachefs
2 participants