Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor eacruntime to efcruntime #3046

Merged

Conversation

yangjun289519474
Copy link
Contributor

Ⅰ. Describe what this PR does

remane eacruntime-controller to efcruntime-controller

Ⅱ. Does this pull request fix one issue?

fixes #3045

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 14, 2023

Hi @yangjun289519474. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #3046 (9b03fa9) into master (2067d65) will increase coverage by 0.04%.
The diff coverage is 84.46%.

❗ Current head 9b03fa9 differs from pull request most recent head 1430c2a. Consider uploading reports for the commit 1430c2a to get more accurate results

@@            Coverage Diff             @@
##           master    #3046      +/-   ##
==========================================
+ Coverage   65.59%   65.63%   +0.04%     
==========================================
  Files         396      396              
  Lines       22836    22864      +28     
==========================================
+ Hits        14979    15007      +28     
  Misses       6102     6102              
  Partials     1755     1755              
Impacted Files Coverage Δ
pkg/ddc/eac/sessmgr.go 0.00% <0.00%> (ø)
pkg/ddc/juicefs/data_load.go 82.26% <ø> (ø)
pkg/ddc/thin/referencedataset/cm.go 46.83% <0.00%> (ø)
pkg/utils/byte_size.go 73.33% <ø> (ø)
pkg/utils/databackup.go 88.00% <ø> (ø)
pkg/ddc/base/runtime.go 69.62% <75.00%> (ø)
pkg/ddc/juicefs/data_migrate.go 80.43% <90.32%> (+3.51%) ⬆️
pkg/ctrl/affinity.go 91.48% <100.00%> (ø)
pkg/ddc/eac/create_volume.go 51.96% <100.00%> (ø)
pkg/ddc/eac/data_load.go 78.84% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cheyang
Copy link
Collaborator

cheyang commented Apr 14, 2023

/test fluid-e2e

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURES] refactor: rename eacruntime-controller to efcruntime-controller
2 participants