Skip to content

Feat/dataload support affinity#2649

Merged
fluid-e2e-bot[bot] merged 5 commits intofluid-cloudnative:masterfrom
allenhaozi:feat/dataload-support-affinity
Mar 5, 2023
Merged

Feat/dataload support affinity#2649
fluid-e2e-bot[bot] merged 5 commits intofluid-cloudnative:masterfrom
allenhaozi:feat/dataload-support-affinity

Conversation

@allenhaozi
Copy link
Contributor

@allenhaozi allenhaozi commented Feb 27, 2023

Ⅰ. Describe what this PR does

dataload support affinity,nodeSelector,tolerations,schedulerName

fixes #2594

Signed-off-by: mahao <allenhaozi@gmail.com>
Signed-off-by: mahao <allenhaozi@gmail.com>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Feb 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@allenhaozi allenhaozi force-pushed the feat/dataload-support-affinity branch from b8dd787 to 2b7e113 Compare February 28, 2023 04:07
@allenhaozi allenhaozi marked this pull request as ready for review February 28, 2023 04:08
@allenhaozi allenhaozi force-pushed the feat/dataload-support-affinity branch 2 times, most recently from da9012d to 43ea88a Compare February 28, 2023 05:38
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #2649 (81da9fc) into master (1c4b690) will increase coverage by 0.03%.
The diff coverage is 76.92%.

❗ Current head 81da9fc differs from pull request most recent head 876ff0c. Consider uploading reports for the commit 876ff0c to get more accurate results

@@            Coverage Diff             @@
##           master    #2649      +/-   ##
==========================================
+ Coverage   67.53%   67.56%   +0.03%     
==========================================
  Files         381      381              
  Lines       21953    21968      +15     
==========================================
+ Hits        14825    14842      +17     
+ Misses       5381     5380       -1     
+ Partials     1747     1746       -1     
Impacted Files Coverage Δ
api/v1alpha1/dataload_types.go 100.00% <ø> (ø)
pkg/ddc/goosefs/load_data.go 83.51% <ø> (ø)
pkg/ddc/jindo/load_data.go 65.42% <ø> (ø)
pkg/ddc/jindofsx/load_data.go 66.05% <ø> (ø)
pkg/ddc/alluxio/load_data.go 85.98% <76.92%> (+2.28%) ⬆️
pkg/webhook/certificate_builder.go 84.09% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@allenhaozi allenhaozi force-pushed the feat/dataload-support-affinity branch from 43ea88a to 9164cbd Compare February 28, 2023 11:24
@allenhaozi
Copy link
Contributor Author

/test fluid-e2e

@TrafalgarZZZ
Copy link
Member

/lgtm

@allenhaozi allenhaozi force-pushed the feat/dataload-support-affinity branch from 9164cbd to 0d151ca Compare March 2, 2023 13:54
@fluid-e2e-bot fluid-e2e-bot bot removed the lgtm label Mar 2, 2023
@TrafalgarZZZ
Copy link
Member

/lgtm

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Mar 3, 2023
@TrafalgarZZZ
Copy link
Member

/test fluid-e2e

@fluid-e2e-bot fluid-e2e-bot bot removed the lgtm label Mar 4, 2023
@allenhaozi
Copy link
Contributor Author

/test fluid-e2e

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
18.7% 18.7% Duplication

@cheyang
Copy link
Collaborator

cheyang commented Mar 5, 2023

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fluid DataLoad Job can add NodeAffinity and Toleration?

3 participants