Default use random port allocator for runtime controllers #2580

TrafalgarZZZ · 2023-02-10T08:32:31Z

Ⅰ. Describe what this PR does

Default to using random port allocator for runtime controllers.
Bitmap-based port allocator is still an option that can be set in runtime controllers' command argument (e.g. --port-allocate-policy=bitmap)

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: dongyun.xzh <[email protected]>

codecov · 2023-02-10T08:52:06Z

Codecov Report

Merging #2580 (c75fc4d) into master (31fe1e5) will increase coverage by 0.07%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master    #2580      +/-   ##
==========================================
+ Coverage   67.51%   67.59%   +0.07%     
==========================================
  Files         368      368              
  Lines       21419    21506      +87     
==========================================
+ Hits        14462    14536      +74     
- Misses       5260     5264       +4     
- Partials     1697     1706       +9

Impacted Files	Coverage Δ
pkg/ddc/base/portallocator/port_allocator.go	`80.76% <69.23%> (-4.95%)`	⬇️
pkg/ddc/juicefs/transform_fuse.go	`78.45% <0.00%> (-2.80%)`	⬇️
pkg/ddc/goosefs/ufs_internal.go	`67.04% <0.00%> (-1.56%)`	⬇️
pkg/ddc/jindo/transform.go	`63.13% <0.00%> (-1.34%)`	⬇️
pkg/ddc/thin/referencedataset/cm.go	`46.83% <0.00%> (-1.22%)`	⬇️
pkg/ddc/jindofsx/transform.go	`64.17% <0.00%> (-0.12%)`	⬇️
pkg/ddc/eac/shutdown.go	`35.95% <0.00%> (ø)`
api/v1alpha1/dataset_types.go	`15.38% <0.00%> (ø)`
pkg/ddc/thin/transform_fuse.go	`66.66% <0.00%> (+0.24%)`	⬆️
pkg/ddc/base/runtime.go	`75.78% <0.00%> (+0.65%)`	⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: dongyun.xzh <[email protected]>

TrafalgarZZZ · 2023-02-10T09:27:37Z

/test fluid-e2e

xliuqq · 2023-02-11T02:42:31Z

pkg/ddc/base/portallocator/port_allocator.go

@@ -61,8 +72,13 @@ type RuntimePortAllocator struct {
 var rpa *RuntimePortAllocator

 // SetupRuntimePortAllocator instantiates the global singleton rpa, use BitMap port allocating policy


please correct the function comment.

xliuqq · 2023-02-11T10:38:46Z

@TrafalgarZZZ @cheyang
Does this PR need to change the value of runtime.portAllocatePolicy from bitmap to random in the fluid chart?

Signed-off-by: dongyun.xzh <[email protected]>

TrafalgarZZZ · 2023-02-13T02:42:20Z

@TrafalgarZZZ @cheyang Does this PR need to change the value of runtime.portAllocatePolicy from bitmap to random in the fluid chart?

@xliuqq LGTM. Added configurable properties in values.yaml of Fluid's chart. Set them to random by default.

cheyang · 2023-02-13T06:42:02Z

/lgtm
/approve

fluid-e2e-bot · 2023-02-13T06:42:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, xliuqq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…dnative#2580) * Validate port allocating policy before setting up Signed-off-by: dongyun.xzh <[email protected]> * Expose configurable option for port allocating policy Signed-off-by: dongyun.xzh <[email protected]> * Fix unit tests Signed-off-by: dongyun.xzh <[email protected]> * Fix static check Signed-off-by: dongyun.xzh <[email protected]> * Fix static check Signed-off-by: dongyun.xzh <[email protected]> * Fix comments for `SetupRuntimePortAllocator()` Signed-off-by: dongyun.xzh <[email protected]> * Support configurable port allocate policy Signed-off-by: dongyun.xzh <[email protected]> --------- Signed-off-by: dongyun.xzh <[email protected]>

…dnative#2580) * Validate port allocating policy before setting up Signed-off-by: dongyun.xzh <[email protected]> * Expose configurable option for port allocating policy Signed-off-by: dongyun.xzh <[email protected]> * Fix unit tests Signed-off-by: dongyun.xzh <[email protected]> * Fix static check Signed-off-by: dongyun.xzh <[email protected]> * Fix static check Signed-off-by: dongyun.xzh <[email protected]> * Fix comments for `SetupRuntimePortAllocator()` Signed-off-by: dongyun.xzh <[email protected]> * Support configurable port allocate policy Signed-off-by: dongyun.xzh <[email protected]> --------- Signed-off-by: dongyun.xzh <[email protected]> Signed-off-by: cheyang <[email protected]>

…dnative#2580) * Validate port allocating policy before setting up Signed-off-by: dongyun.xzh <[email protected]> * Expose configurable option for port allocating policy Signed-off-by: dongyun.xzh <[email protected]> * Fix unit tests Signed-off-by: dongyun.xzh <[email protected]> * Fix static check Signed-off-by: dongyun.xzh <[email protected]> * Fix static check Signed-off-by: dongyun.xzh <[email protected]> * Fix comments for `SetupRuntimePortAllocator()` Signed-off-by: dongyun.xzh <[email protected]> * Support configurable port allocate policy Signed-off-by: dongyun.xzh <[email protected]> --------- Signed-off-by: dongyun.xzh <[email protected]>

…dnative#2580) * Validate port allocating policy before setting up Signed-off-by: dongyun.xzh <[email protected]> * Expose configurable option for port allocating policy Signed-off-by: dongyun.xzh <[email protected]> * Fix unit tests Signed-off-by: dongyun.xzh <[email protected]> * Fix static check Signed-off-by: dongyun.xzh <[email protected]> * Fix static check Signed-off-by: dongyun.xzh <[email protected]> * Fix comments for `SetupRuntimePortAllocator()` Signed-off-by: dongyun.xzh <[email protected]> * Support configurable port allocate policy Signed-off-by: dongyun.xzh <[email protected]> --------- Signed-off-by: dongyun.xzh <[email protected]> Signed-off-by: cheyang <[email protected]>

) * Validate port allocating policy before setting up * Expose configurable option for port allocating policy * Fix unit tests * Fix static check * Fix static check * Fix comments for `SetupRuntimePortAllocator()` * Support configurable port allocate policy --------- Signed-off-by: dongyun.xzh <[email protected]> Signed-off-by: cheyang <[email protected]> Co-authored-by: TzZtzt <[email protected]>

TrafalgarZZZ added 4 commits February 10, 2023 16:07

Validate port allocating policy before setting up

44f99e6

Signed-off-by: dongyun.xzh <[email protected]>

Expose configurable option for port allocating policy

a1d21a8

Signed-off-by: dongyun.xzh <[email protected]>

Fix unit tests

d9633cd

Signed-off-by: dongyun.xzh <[email protected]>

Fix static check

b9bcb29

Signed-off-by: dongyun.xzh <[email protected]>

Fix static check

4a7479c

Signed-off-by: dongyun.xzh <[email protected]>

cheyang requested a review from xliuqq February 10, 2023 11:28

xliuqq reviewed Feb 11, 2023

View reviewed changes

TrafalgarZZZ added 2 commits February 13, 2023 10:28

Fix comments for SetupRuntimePortAllocator()

acdfb89

Signed-off-by: dongyun.xzh <[email protected]>

Support configurable port allocate policy

c75fc4d

Signed-off-by: dongyun.xzh <[email protected]>

xliuqq approved these changes Feb 13, 2023

View reviewed changes

fluid-e2e-bot bot assigned cheyang Feb 13, 2023

fluid-e2e-bot bot added the lgtm label Feb 13, 2023

fluid-e2e-bot bot added the approved label Feb 13, 2023

fluid-e2e-bot bot merged commit d02e807 into fluid-cloudnative:master Feb 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Default use random port allocator for runtime controllers #2580

Default use random port allocator for runtime controllers #2580

TrafalgarZZZ commented Feb 10, 2023

codecov bot commented Feb 10, 2023 •

edited

Loading

TrafalgarZZZ commented Feb 10, 2023

xliuqq Feb 11, 2023

TrafalgarZZZ Feb 13, 2023

xliuqq commented Feb 11, 2023 •

edited

Loading

TrafalgarZZZ commented Feb 13, 2023

cheyang commented Feb 13, 2023

fluid-e2e-bot bot commented Feb 13, 2023

		@@ -61,8 +72,13 @@ type RuntimePortAllocator struct {
		var rpa *RuntimePortAllocator

		// SetupRuntimePortAllocator instantiates the global singleton rpa, use BitMap port allocating policy

Default use random port allocator for runtime controllers #2580

Default use random port allocator for runtime controllers #2580

Conversation

TrafalgarZZZ commented Feb 10, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov bot commented Feb 10, 2023 • edited Loading

Codecov Report

TrafalgarZZZ commented Feb 10, 2023

xliuqq Feb 11, 2023

Choose a reason for hiding this comment

TrafalgarZZZ Feb 13, 2023

Choose a reason for hiding this comment

xliuqq commented Feb 11, 2023 • edited Loading

TrafalgarZZZ commented Feb 13, 2023

cheyang commented Feb 13, 2023

fluid-e2e-bot bot commented Feb 13, 2023

codecov bot commented Feb 10, 2023 •

edited

Loading

xliuqq commented Feb 11, 2023 •

edited

Loading