Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for clean cache #2529

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Jan 28, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #2526

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #2529 (40c5c5b) into master (7c5661a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2529   +/-   ##
=======================================
  Coverage   67.55%   67.55%           
=======================================
  Files         367      367           
  Lines       21267    21266    -1     
=======================================
  Hits        14366    14366           
+ Misses       5218     5217    -1     
  Partials     1683     1683           
Impacted Files Coverage Δ
pkg/ddc/alluxio/shutdown.go 44.84% <ø> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jan 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit ee2d1cf into fluid-cloudnative:master Jan 29, 2023
cheyang added a commit to cheyang/fluid that referenced this pull request Feb 14, 2023
* Set default value for cleanCachePolicy, To #46827170

Signed-off-by: cheyang <[email protected]>

* Set default value for  cache clean policy, To #46827170

Signed-off-by: cheyang <[email protected]>

* Set default value for cleanCachePolicy, To #46827170

Signed-off-by: cheyang <[email protected]>

* Set default value for cleanCachePolicy, To #46827170

Signed-off-by: cheyang <[email protected]>

* Set default value for cleanCachePolicy, To #46827170

Signed-off-by: cheyang <[email protected]>

* Set default value for cleanCachePolicy, To #46827170

Signed-off-by: cheyang <[email protected]>

---------

Signed-off-by: cheyang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Set default value for clean cache policy
2 participants