Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent-bit: added ability to set extra config reload dirs #561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndrewChubatiuk
Copy link

added ability to set extra dirs for hot reloader

@stevehipwell
Copy link
Collaborator

@AndrewChubatiuk do you have an example of what this fixes and have you tested the changes work as expected?

@AndrewChubatiuk
Copy link
Author

AndrewChubatiuk commented Oct 28, 2024

hey @stevehipwell
We're using a fluent-bit chart as a dependency and cannot use parent chart template to generate Host value, that's why we're creating a custom ConfigMap, mounting it inside fluent-bit using @Include to use this file, but hot reload for a custom mount path or for nested mounts is not working, that's why adding extra paths for config-reloader is needed

@stevehipwell
Copy link
Collaborator

@AndrewChubatiuk have you tested this out? There are limitations to what files can be reloaded. @patrick-stephens do you have any more context on the reload system?

@AndrewChubatiuk
Copy link
Author

it's working, there's a link in PR, where I've added a workaround to a chart till it's not merged

@patrick-stephens
Copy link
Contributor

Reload only supports http or signal based approaches if that's what you mean?

I suspect this is about the trigger for the reload right?

@AndrewChubatiuk
Copy link
Author

yes, it's needed for triggering http endpoint on changes in a file systemd

@stevehipwell
Copy link
Collaborator

@patrick-stephens I was thinking about the limitations and current issues such as fluent/fluent-bit#8918.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants