Propagate default value change from subclass of compat plugins #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| CONFIGURABLE_CLASS_METHODS.instance_method(:config_section).bind(self).call(:buffer) do | ||
| self.config_set_default newer, defval | ||
| p(name: name, newer: newer, defval: defval, defaults: self.defaults) |
There was a problem hiding this comment.
pushed a commit to remove these debug print.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd party plugins with v0.12 APIs may change default values of parameters, which is controlled by compat layers. This change should be propagated to defaults of
<buffer>section.This change fixes #995.