Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Fluent::Plugin::BareOutput to support v0.12 MultiOutput plugins #974

Merged
merged 2 commits into from
May 23, 2016

Conversation

tagomoris
Copy link
Member

No description provided.

@tagomoris
Copy link
Member Author

@sonots Please check this change

@sonots
Copy link
Member

sonots commented May 21, 2016

For the problem of ERROR2 of #973, I got another error for config-expander as

Error: test_emit(ConfigExpanderOutputTest): RuntimeError: BUG: use router.emit instead of Engine.emit

I also have one question: what does "bare" infer? How plugin developers choose a parent class, Output or BareOutput to create an output plugin?

@tagomoris
Copy link
Member Author

It's intentional to prohibit Engine.emit... it will not be fixed so far.
BareOutput is very limited and skinny one, and it's not for almost plugin authors. it's just for meta plugins like forest, config-expander or something like that.

@sonots
Copy link
Member

sonots commented May 21, 2016

Okay, so compatibility layer for Engine.emit is not provided.
I understand that we have to tell about it to plugin developers.

Code itself looks good to me.

@tagomoris
Copy link
Member Author

Once I thought about Engine.emit, but that is just under Fluent::, and no space to override for compatibilities. And that change is of v0.12 originally (we should have shown "deprecated" message in v0.12 versions).

@tagomoris
Copy link
Member Author

I added some comment to tell not to use this for normal output plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants