Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing error class and test for out_forward #922

Merged
merged 3 commits into from
Apr 28, 2016

Conversation

tagomoris
Copy link
Member

This change is to use BufferedOutputTestDriver in test_out_forward.

I added some fixes in this change. These are related with each other.

  • ForwardOutput plugin will raise an error for missing ACK, but it's not defined in the patch
    • It was missed because
  • ObjectBufferedOutput does NOT have #format_stream and doing it in #emit directly
    • BufferedOutputTestDriver does NOT call #emit, and use #format_stream and chunk << data directly
  • BufferedOutputTestDriver and TimeSlicedOutputTestDriver called block.call after chunking events
    • It's simply wrong, because d.emit in blocks don't work with such code
  • Assigning Engine is already outdated

@tagomoris tagomoris force-pushed the fix-missing-error-class-and-test branch from 2441644 to 7b67387 Compare April 27, 2016 13:35
@tagomoris tagomoris merged commit 91e3516 into master Apr 28, 2016
@tagomoris tagomoris deleted the fix-missing-error-class-and-test branch May 17, 2016 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant