-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suspend option to in dummy plugin #900
Add suspend option to in dummy plugin #900
Conversation
99d8626
to
6c138c9
Compare
78e2e69
to
d87934e
Compare
Please leave |
And, could you rebase changes of |
d87934e
to
0801089
Compare
I've rebased with current master. |
0c616dc
to
1543ce4
Compare
Oh.... I think almost storage_local code should be leave as-is. But this line https://github.com/fluent/fluentd/pull/900/files#diff-0380de12f73675c40904702aab31701cR61 should be fixed because without this fix I always got the following error:
|
It's time to revoke this thread, and there is just a point to be fixed after many fixes during pending time. |
@@ -58,12 +60,16 @@ def initialize | |||
def configure(conf) | |||
super | |||
@dummy_index = 0 | |||
config = conf.elements.select{|e| e.name == 'storage' }.first | |||
@storage = storage_create(usage: 'suspend', conf: config, type: :local) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase this tree on master, and please use default_type
instead of type keyword argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll try your suggested changes within a week.
936c60f
to
dcdebeb
Compare
LGTM! |
Thanks!!! |
No description provided.