Remove redundant require
#892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #848 |
| @@ -15,7 +15,6 @@ | |||
| # | |||
|
|
|||
| require 'fluent/configurable' | |||
| require 'fluent/engine' | |||
There was a problem hiding this comment.
Removing this require looks good, but Engine is referred below to get logger.
I think we need to fix Agent to get logger in constructor, and to pass it from Engine when RootAgent is created in engine.rb.
|
@okkez I added some comments. Could you add some more fixes? |
|
🆗 I will push fixes in this week. |
This change suppresses following warnings(about 130 lines warnings): lib/fluent/config/configure_proxy.rb:17: warning: loading in progress, circular require considered harmful lib/fluent/config/types.rb:20: warning: loading in progress, circular require considered harmful lib/fluent/event.rb:17: warning: loading in progress, circular require considered harmful lib/fluent/filter.rb:19: warning: loading in progress, circular require considered harmful lib/fluent/agent.rb:18: warning: loading in progress, circular require considered harmful lib/fluent/output.rb:21: warning: loading in progress, circular require considered harmful lib/fluent/root_agent.rb:21: warning: loading in progress, circular require considered harmful
okkez
force-pushed
the
remove-circular-require
branch
from
7fdfbe6 to
4d43a98
Compare
|
I've pushed fixes for all comments. |
|
Hmm, CI failed. |
|
CI failed against cc73ce2. |
|
Thank you very much! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change suppresses following warnings(about 130 lines warnings):
lib/fluent/config/configure_proxy.rb:17: warning: loading in progress, circular require considered harmful
lib/fluent/config/types.rb:20: warning: loading in progress, circular require considered harmful
lib/fluent/event.rb:17: warning: loading in progress, circular require considered harmful
lib/fluent/filter.rb:19: warning: loading in progress, circular require considered harmful
lib/fluent/agent.rb:18: warning: loading in progress, circular require considered harmful
lib/fluent/output.rb:21: warning: loading in progress, circular require considered harmful
lib/fluent/root_agent.rb:21: warning: loading in progress, circular require considered harmful