Rakefile: Suppress warnings from ruby, enabled by rake 11 #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
changed the title
|
Warnings should be resolved. I think so too. I created issue for that. #848 |
tagomoris
changed the title
tagomoris
added a commit
that referenced
this pull request
Mar 11, 2016
Rakefile: Suppress warnings from ruby, enabled by rake 11
|
Merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rake 11.0.1 or later,
t.warning = trueis by default. This behavior had been introduced in ruby/rake#97.Should we suppress warnings from the new rake?
Or should we resolve warnings in Fluentd side?
IMO, concealing warnings is not good for Fluend. It reports potential problem which should be fixed in the future.