separate PluginId module from config.rb #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tagomoris
commented
Mar 8, 2016
tagomoris
commented
- simply speaking, it's wrong file to write it
- added a feature to check whether id is intentionally set by user or not
- it's important to check whether we can create many thing depends on id or not
- for example, id-based auto generated buffer path, and plugin storage on local filesystem
tagomoris
force-pushed
the
separate-plugin-id-class
branch
2 times, most recently
from
ebefc84
to
f7e8d6f
Compare
|
|
||
| module Fluent | ||
| module PluginId | ||
| @@configured_ids = {} |
There was a problem hiding this comment.
It seems stored values are not used.
Using Set or Array is better for memory usage and GC pressure.
There was a problem hiding this comment.
Ah, that's right. I'll use it.
* simply speaking, it's wrong file to write it * added a feature to check whether id is intentionally set by user or not * it's important to check whether we can create many thing depends on id or not * for example, id-based auto generated buffer path, and plugin storage on local filesystem
tagomoris
force-pushed
the
separate-plugin-id-class
branch
from
f7e8d6f
to
9219165
Compare
|
I modified commits:
|
tagomoris
added a commit
that referenced
this pull request
Mar 10, 2016
separate PluginId module from config.rb
|
Merged. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.