enforce new hash syntax by rubocop --only HashSyntax --auto-correct
#795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :log => log, | ||
| :auto_typecast => @auto_typecast, | ||
| log: log, | ||
| auto_typecast: @auto_typecast, |
There was a problem hiding this comment.
it has just 2 fields and these are far different from each other. There seems no problem.
|
@repeatedly I'm about to merge this change after confirmation for green. Are you ok? |
|
Dows this syntax work on ruby 1.9? |
|
It's the new feature for Ruby 1.9. |
|
I see. Okay. |
tagomoris
added a commit
that referenced
this pull request
Feb 9, 2016
enforce new hash syntax by `rubocop --only HashSyntax --auto-correct`
|
Merged. |
cosmo0920
pushed a commit
to cosmo0920/fluentd
that referenced
this pull request
Feb 16, 2016
enforce new hash syntax by `rubocop --only HashSyntax --auto-correct`
repeatedly
added a commit
that referenced
this pull request
Feb 16, 2016
Back port enforce new hash syntax by `rubocop --only HashSyntax --auto-correct` (#795)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did syntax check for all .rb files by
find . -name '*.rb' | xargs -n 1 ruby -c