Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compression in forward transfer #637

Closed
wants to merge 1 commit into from

Conversation

repeatedly
Copy link
Member

Experimental implementation.

Adding compress true in out_forward configuration.

@dhiltonp
Copy link

dhiltonp commented Dec 7, 2015

Can we get feedback on this PR? Is it going to be merged? Is there a reason for it to not be merged? Is there something that needs to be fixed in this code before it is accepted?

Thanks!

@repeatedly
Copy link
Member Author

We need feedback on several enviroment for checking performance and compression ratio with actual logs.
I post it on #504 but there is no feedback so I'm pending the merge.

@repeatedly
Copy link
Member Author

BTW, now this branch conflicts with master.
I will update the patch later.

@repeatedly repeatedly force-pushed the forward-gzip-compression branch from a005481 to acbbadd Compare December 10, 2015 19:49
@repeatedly
Copy link
Member Author

rebased for testing.

@tagomoris
Copy link
Member

At least, this change doesn't include tests.

@repeatedly
Copy link
Member Author

Yes because we need test with production traffic.
If this change is useful, I will add tests.

BTW, I will rebase this branch.

@Manikantan22
Copy link

Do we still have "compress true" for out_forward plugin?

I am using td-agent2 and tried to use compress true but getting below error in logs.

[warn]: parameter 'compress' in is not used.

@repeatedly
Copy link
Member Author

repeatedly commented Apr 21, 2016

compress doesn't support yet in the upstream
because this patch is not merged yet.

@tagomoris tagomoris added the pending To be done in the future label Aug 3, 2016
@tagomoris
Copy link
Member

This feature will be supported with compressed buffer. Pending.

@repeatedly
Copy link
Member Author

#1179 is more better way. I close this PR.

@repeatedly repeatedly closed this Aug 25, 2016
@ganmacs ganmacs deleted the forward-gzip-compression branch July 11, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending To be done in the future v0.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants