Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jeweler, and fix to depend gem building on bundler #61

Closed
wants to merge 1 commit into from

Conversation

tagomoris
Copy link
Member

Fix Gemfile/Rakefile/gemspec to use bundler for building .gem
'jeweler' is not maintained today.

@repeatedly
Copy link
Member

LGTM 👍

@tagomoris
Copy link
Member Author

NOTE: someone must edit gem.description before first release with this gemspec

@frsyuki
Copy link
Member

frsyuki commented Aug 18, 2012

I agree jeweler is obsoleted and bundler is better.
But when we once switched to bundler, it caused a problem for RPM/deb packaging.
(b8871f8 and 165a572)
So we need to fix the packaging scripts first at the same time.

@frsyuki
Copy link
Member

frsyuki commented Sep 26, 2012

Sorry, this issue is taking time...

@tagomoris
Copy link
Member Author

Ruby 2.0.0 doesn't have 'rubygems/builder', so we cannot rake build with jeweler...

@repeatedly
Copy link
Member

treasure-data/td-agent@8e21c23

I tried above commit and building td-agent RPM succeeded on CentOS 6.4.

I am now trying deb package with bundler based fluentd.
But unfortunately, I can't build the deb package in the first place.
Need more time...

@suupic
Copy link

suupic commented Mar 23, 2013

I switch jeweler to bundler and build rpm use td-agent's build script, it works fine

@repeatedly
Copy link
Member

@suupic

build rpm use td-agnet's build script, it works fine

Which branch did you use, master or bundler-fluentd-support?

@suupic
Copy link

suupic commented Mar 24, 2013

@repeatedly
I use master, but I replaced Rakefile and fluentd.gemspec. Those two file come from branch goodbye-jeweler.
but I only tied rpm, not deb

@tagomoris tagomoris closed this Mar 28, 2013
@tagomoris tagomoris deleted the bundlernize branch March 28, 2013 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants