transport tls: use SSL_VERIFY_NONE by default #4718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
Use SSL_VERIFY_NONE by default for transport tls.
(VERIFY_PEER is used by default now).
VERIFY_NONE should be used when
client_cert_auth false
(default).Before this fix, we need to set
insecure true
for this.However,
insecure
option should mainly be for cipher strength.It would not be intended VERIFY_PEER without VERIFY_FAIL_IF_NO_PEER_CERT was used even if
client_cert_auth false
.(When VERIFY_PEER without VERIFY_FAIL_IF_NO_PEER_CERT, server does certification only when clients send its certificate.
This would be why we overlooked it long time)
Before:
After:
Docs Changes:
Not needed.
Release Note:
The same as the title.