Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_config: add source_only_buffer to SYSTEM_CONFIG_PARAMETERS #4715

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Nov 26, 2024

Which issue(s) this PR fixes:

What this PR does / why we need it:
Need this to the section handled in SystemConfig#dup.
This should be added to SYSTEM_CONFIG_PARAMETERS, though this is not affected to the actual behavior,

Note: I don't understand why log section is not added. Maybe it should be added as well.
(It should be done by another PR).

Docs Changes:
Not needed

Release Note:
Not needed

Need this to the section handled in `SystemConfig#dup`.

This should be added to SYSTEM_CONFIG_PARAMETERS, though this is
not affected to the actual behavior,

Note: I don't understand why `log` section is not added. Maybe it
should be added as well.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom requested review from Watson1978 and kenhys November 26, 2024 01:44
@daipom daipom added this to the v1.18.0 milestone Nov 26, 2024
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daipom daipom merged commit 89f0a76 into fluent:master Nov 26, 2024
13 of 16 checks passed
@daipom daipom deleted the system_config-add-source_only_buffer-to-SYSTEM_CONFIG_PARAMETERS branch November 26, 2024 03:13
@daipom
Copy link
Contributor Author

daipom commented Nov 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants