Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_cat: use proper protocol in unused_port method #4686

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

Watson1978
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #4674

What this PR does / why we need it:
Fixes an issue where an inappropriate protocol was specified in the unused_port method.
See #4674 (comment)

Docs Changes:

Release Note:

@daipom daipom self-requested a review October 28, 2024 07:02
@daipom
Copy link
Contributor

daipom commented Oct 28, 2024

Thanks, but it should be tcp.
There must be another reason why this test fails.

ref: #4674 (comment)

@daipom daipom closed this Oct 28, 2024
@daipom daipom reopened this Oct 28, 2024
@daipom
Copy link
Contributor

daipom commented Oct 28, 2024

#4674 (comment)

If there is a possibility of using TCP, it will need to take care of both.

it may be a good idea to take care of both!

test/command/test_cat.rb Outdated Show resolved Hide resolved
Watson1978 and others added 2 commits October 28, 2024 16:44
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit add96bb into fluent:master Oct 28, 2024
14 of 16 checks passed
@Watson1978
Copy link
Contributor Author

Thanks!

@Watson1978 Watson1978 deleted the fix-unused_port branch October 28, 2024 11:03
@kenhys kenhys mentioned this pull request Nov 28, 2024
@daipom daipom added the backport to LTS We will backport this fix to the LTS branch label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to LTS We will backport this fix to the LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Fails with "Errno::EACCES: Permission denied - bind(2)" on Windows
2 participants