Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_in_udp: Reduce execution time of message_length_limit test #4682

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ashie
Copy link
Member

@ashie ashie commented Oct 22, 2024

Which issue(s) this PR fixes:
N/A

What this PR does / why we need it:
Although it's improved in #4676, it still takes 5 seconds on windows.
It can be reduced more by sending data that doesn't exceed the limit.

  test: message_length_limit:                           .: (1.104855)

Docs Changes:
N/A

Release Note:
N/A

Although it's improved in #4676, it still takes 5 seconds on windows.
It can be reduced more by sending data that doesn't exceed the limit.

```
  test: message_length_limit:                           .: (1.104855)
```

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie requested review from Watson1978 and daipom October 22, 2024 01:15
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ashie
Copy link
Member Author

ashie commented Oct 22, 2024

A remaining failed test will be handled in another issue or PR:

1) Failure: test: multiple values are set to RUBYOPT(TestFluentdCommand::configured to run 2 workers):
  log doesn't match.

@ashie ashie merged commit f493f25 into master Oct 22, 2024
16 of 18 checks passed
@ashie ashie deleted the reduce-test-execution-time branch October 22, 2024 01:52
@daipom daipom added the backport to LTS We will backport this fix to the LTS branch label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to LTS We will backport this fix to the LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants