-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http_server: Ready to support Async 2.0 gem #4619
Conversation
How are you using |
By the way, I'm sorry that this is complicated, I did not intend for this to become a big problem. I'm happy to advise or help out. |
Thanks for your comment! We may need to start considering it now. |
Is it exposed to user code or is it all internal implementation? |
Partially wrapped by our API but Coolio's classes are exposed to plugins. fluentd/lib/fluent/plugin/in_tail.rb Lines 821 to 849 in 7f13c7a
|
I see, it's a tricky change then. One option would be to change |
Rebased with master in order to run CI with |
Ah, we also need to fix |
@ioquatix If you have a time, I want you will take an action for socketry/io-event#112 🙏🏻 |
Signed-off-by: Takuro Ashie <[email protected]> Signed-off-by: Shizuo Fujita <[email protected]>
Because dependent io-event (v1.0.9) can't build on Windows. Signed-off-by: Takuro Ashie <[email protected]> Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]> Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]> Signed-off-by: Shizuo Fujita <[email protected]>
This reverts commit 895fa6b. Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it with in_monitor_agent, it works fine for me.
Thanks a lot!
Awesome! |
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
http_server plugin helper doesn't work with Async 2.x gem due to using obsolete usage.
This PR updates it to follow current documented way:
https://github.com/socketry/async-http/blob/0a65acd7cf7486e1877f0da86580e1692cd8207b/readme.md#usage
It's applicable both Async 2.x & Async 1.x.
But this PR still stay on Async 1.x because io-event gem which is required by Async 2.x can't build on Windows.Replacecool.io
gem to somethingDocs Changes:
Release Note: