Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_config: add path attribute in system/log section #4604

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Aug 19, 2024

Which issue(s) this PR fixes:
Fixes #4418

What this PR does / why we need it:
This patch will add path attribute in sytem/log section due to configure log file path by System Configuration.

Docs Changes:
fluent/fluentd-docs-gitbook#516

Release Note:
The same as the title.

@Watson1978 Watson1978 changed the title sytem_config: add log_path attribute in system section system_config: add log_path attribute in system section Aug 19, 2024
@Watson1978 Watson1978 marked this pull request as ready for review August 19, 2024 08:10
@Watson1978 Watson1978 marked this pull request as draft August 19, 2024 08:12
@Watson1978 Watson1978 changed the title system_config: add log_path attribute in system section system_config: add path attribute in system/log section Aug 19, 2024
This patch will add `path` attribute in sytem/log section due to configure log file path  by System Configuration.

Signed-off-by: Watson <[email protected]>
@Watson1978 Watson1978 marked this pull request as ready for review August 19, 2024 08:56
Copy link
Member

@ashie ashie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashie ashie requested a review from daipom August 20, 2024 00:56
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom added this to the v1.18.0 milestone Aug 20, 2024
@daipom daipom merged commit df9b04d into fluent:master Sep 24, 2024
16 checks passed
@daipom
Copy link
Contributor

daipom commented Sep 24, 2024

@Watson1978 If you have time, it would be great if you could update the document.

@Watson1978 Watson1978 deleted the log_path branch September 24, 2024 12:54
Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Sep 25, 2024
Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Sep 25, 2024
This feature was introduced at fluent/fluentd#4604

Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Sep 26, 2024
This feature was introduced at fluent/fluentd#4604

Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978 added a commit to Watson1978/fluentd-docs-gitbook that referenced this pull request Sep 27, 2024
This feature was introduced at fluent/fluentd#4604

Signed-off-by: Shizuo Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set log_path in system config
3 participants