-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system_config: add path attribute in system/log section #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
changed the title
sytem_config: add log_path attribute in system section
system_config: add log_path attribute in system section
Aug 19, 2024
Watson1978
changed the title
system_config: add log_path attribute in system section
system_config: add path attribute in system/log section
Aug 19, 2024
This patch will add `path` attribute in sytem/log section due to configure log file path by System Configuration. Signed-off-by: Watson <[email protected]>
ashie
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
daipom
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@Watson1978 If you have time, it would be great if you could update the document. |
Watson1978
added a commit
to Watson1978/fluentd-docs-gitbook
that referenced
this pull request
Sep 25, 2024
This feature was introduced at fluent/fluentd#4604 Signed-off-by: Watson <[email protected]>
Watson1978
added a commit
to Watson1978/fluentd-docs-gitbook
that referenced
this pull request
Sep 25, 2024
This feature was introduced at fluent/fluentd#4604 Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978
added a commit
to Watson1978/fluentd-docs-gitbook
that referenced
this pull request
Sep 26, 2024
This feature was introduced at fluent/fluentd#4604 Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978
added a commit
to Watson1978/fluentd-docs-gitbook
that referenced
this pull request
Sep 27, 2024
This feature was introduced at fluent/fluentd#4604 Signed-off-by: Shizuo Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4418
What this PR does / why we need it:
This patch will add
path
attribute in sytem/log section due to configure log file path by System Configuration.Docs Changes:
fluent/fluentd-docs-gitbook#516
Release Note:
The same as the title.