Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1.17.1 #4593

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Add v1.17.1 #4593

merged 1 commit into from
Aug 19, 2024

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Aug 15, 2024

Which issue(s) this PR fixes:

Fixes #

What this PR does / why we need it:

Let's make a point release.

Docs Changes:

N/A

Release Note:

N/A

@kenhys
Copy link
Contributor Author

kenhys commented Aug 15, 2024

@ashie
Copy link
Member

ashie commented Aug 16, 2024

* [Extend Embedded Ruby Code support for Hashes and Arrays #4580](https://github.com/fluent/fluentd/pull/4580)

It should be v1.18 or later as I mentioned in #4580 (comment)
Please exclude it in v1.17.1.

@kenhys kenhys force-pushed the release-v1.17.1 branch 2 times, most recently from a32cc85 to c633fbe Compare August 19, 2024 02:01
@kenhys kenhys marked this pull request as ready for review August 19, 2024 02:01
@kenhys
Copy link
Contributor Author

kenhys commented Aug 19, 2024

Added last one piece for v1.17.1 in CHANGELOG.

@kenhys kenhys requested a review from daipom August 19, 2024 02:03
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I have commented on some points.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Kentaro Hayashi <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my typo! Thanks for fixing it!
LGTM.

@kenhys kenhys merged commit 78a7972 into fluent:master Aug 19, 2024
14 of 16 checks passed
@kenhys kenhys deleted the release-v1.17.1 branch August 19, 2024 05:59
@kenhys
Copy link
Contributor Author

kenhys commented Aug 19, 2024

Thank you for reviewing!

@daipom daipom added this to the v1.17.1 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants