github: stop using rendering for freestyle text area #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not happy about free style text area being enclosed in a code block automatically. Signed-off-by: Daijiro Fukuda <[email protected]>
|
@kenhys Could you check this when you have time? (this is not urgent) |
ashie
approved these changes
May 29, 2024
kenhys
approved these changes
May 29, 2024
There was a problem hiding this comment.
As there is no preview feature when posting discussion topic, so it may be difficult to
expect that discussion form will be rendered with markdown or not.
It was intentional to apply render: markdown itself, but if it is harmful in practical use case, it should be removed.
|
Thanks for your review! |
I see! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
Stop using rendering for freestyle text area.
Not happy about free style text area being enclosed in a code block automatically.
I think this is not intended, right?
If there is a reason, please let me know.
Q&A:
Docs Changes:
Not needed.
Release Note:
Not needed.