-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_file: add warn message for symlink_path setting #4502
Merged
daipom
merged 2 commits into
fluent:master
from
Shingo-Nakayama:out_file-add-warn-message-for-symlink_path-setting
May 29, 2024
Merged
out_file: add warn message for symlink_path setting #4502
daipom
merged 2 commits into
fluent:master
from
Shingo-Nakayama:out_file-add-warn-message-for-symlink_path-setting
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shingo Nakayama <[email protected]>
daipom
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
Could you please fix the following points?
Signed-off-by: Shingo Nakayama <[email protected]> Co-authored-by: Daijiro Fukuda <[email protected]>
Shingo-Nakayama
force-pushed
the
out_file-add-warn-message-for-symlink_path-setting
branch
from
May 24, 2024 06:44
5b85ac8
to
1a64c6e
Compare
daipom
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
daipom
changed the title
out_file:add warn message for symlink_path-setting
out_file: add warn message for symlink_path setting
May 29, 2024
daipom
added a commit
that referenced
this pull request
May 29, 2024
Backported from 74b2e3d. Signed-off-by: Shingo Nakayama <[email protected]> Co-authored-by: Daijiro Fukuda <[email protected]>
daipom
added a commit
that referenced
this pull request
May 29, 2024
Backported from 74b2e3d. Signed-off-by: Shingo Nakayama <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Daijiro Fukuda <[email protected]>
daipom
added a commit
that referenced
this pull request
May 29, 2024
Backported from 74b2e3d. (#4502) Signed-off-by: Shingo Nakayama <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Shingo Nakayama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
According to the issue #4490 , if a
tag
orkeys
is set in the chunk key and those placeholders do not exist in thesymlink_path
, multiple chunks to compete for the same symlink and some logs can't be taken from it.Since this is unintended behavior, I think it is necessary to inform the user that this is a bad setting by the warn message.
If a
tag
orkeys
is set in the chunk key and those placeholders do not exist in thesymlink_path
, the following warning log is displayed.Ex:
Docs Changes:
None (may be necessary)
Release Note:
Same with the title