Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.16: keep console v1.24 #4500

Closed
wants to merge 1 commit into from
Closed

v1.16: keep console v1.24 #4500

wants to merge 1 commit into from

Conversation

daipom
Copy link
Contributor

@daipom daipom commented May 22, 2024

Which issue(s) this PR fixes:

What this PR does / why we need it:
console gem v1.25 causes LoadError because it has changed some namepaths (#4487).
v1.25 has been supported on the master branch at #4492, but on v1.16, we should keep v1.24 to prioritize stability.

Docs Changes:
Not needed.

Release Note:
Not needed since there is no specification change.

@daipom
Copy link
Contributor Author

daipom commented May 22, 2024 •
edited
Loading

I am concerned about how CI fails...

@daipom
Copy link
Contributor Author

daipom commented May 22, 2024

I am concerned about how CI fails...

* https://github.com/fluent/fluentd/actions/runs/9189163333/job/25270604120?pr=4500

Sorry, I missed that environments using Ruby 2 had been using the console gem version 1.19.0.
We need to fix the dependency condition.

@daipom
Copy link
Contributor Author

daipom commented May 22, 2024

It seems < 1.25.0 would be the correct condition for us.

@daipom
v1.16: keep console v1.24
f493c71 
console gem v1.25 causes LoadError because it has changed some
namepaths (#4487).
v1.25 has been supported on the master branch at
b15cda4, but on v1.16, we should
keep v1.24 to prioritize stability.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom force-pushed the v1.16-keep-console-v1.24 branch from a9a6241 to f493c71 Compare May 22, 2024 10:01
@daipom
Copy link
Contributor Author

daipom commented May 22, 2024

I have confirmed failing tests are about

So, merging this and #4489 will resolve the current CI issue for v1.16.

On the other hand, I came up with a another solution to keep console < v1.24.0 (not < v1.25.0).
Then, we don't even need #4489.

@daipom
Copy link
Contributor Author

daipom commented May 24, 2024

On the other hand, I came up with a another solution to keep console < v1.24.0

I'm going to check if it has anything to do with vulnerability.

@daipom
Copy link
Contributor Author

daipom commented May 28, 2024 •
edited
Loading

On the other hand, I came up with a another solution to keep console < v1.24.0

I'm going to check if it has anything to do with vulnerability.

I have confirmed this has nothing to do with vulnerability.
Using bundler-audit, I have confirmed that keeping the console < v1.24 does not increase vulnerability of dependencies both in Ruby 3 and Ruby 2.

Let's keep console < v1.24 in the v1.16 branch.

@daipom daipom closed this May 28, 2024
@daipom
Copy link
Contributor Author

daipom commented May 28, 2024

Let's keep console < v1.24 in the v1.16 branch.

I have made a PR for this:

@daipom daipom deleted the v1.16-keep-console-v1.24 branch May 29, 2024 01:24
@daipom daipom added this to the v1.16.6 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashie ashie ashie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.16.6
Development

Successfully merging this pull request may close these issues.
2 participants
@daipom @ashie