Add missing dependency to base64 #4425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ruby 3.4.0, base64 is changed to non-default gems. It need to be installed explicitly now. (service discovery and out forward plugin use it) At least base64 >= 0.1.0 should be installed. FYI: * ruby 3.0.0 (base64 0.1.0) * ruby 3.0.6 (base64 0.1.0) * ruby 3.1.4 (base64 0.1.1) * ruby 3.2.3 (base64 0.1.1) * ruby 3.3.0 (base64 0.2.0) It seems that ruby-2.7.8 bundles base64 0.1.0 equivalent version. e.g. It fixes the following LoadError. warning: base64 was loaded from the standard library, but is not part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundled_gems.rb:74:in 'Kernel.require': cannot load such file -- base64 (LoadError) Signed-off-by: Kentaro Hayashi <[email protected]>
|
I'm working on it at #4411 |
|
I've overlooked it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Since ruby 3.4.0, base64 is changed to non-default gems. It need to be installed explicitly now.
(service discovery and out forward plugin use it)
At least base64 >= 0.1.0 should be installed.
FYI:
It seems that ruby-2.7.8 bundles base64 0.1.0 equivalent version.
e.g. It fixes the following LoadError.
warning: base64 was loaded from the standard library, but is not part
of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or
gemspec.
/home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/bundled_gems.rb:74:in
'Kernel.require': cannot load such file -- base64 (LoadError)
Docs Changes:
N/A
Release Note:
N/A