Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace deprecated method #4344

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Nov 17, 2023

Which issue(s) this PR fixes:
None.

What this PR does / why we need it:
Because Bundler.with_clean_env has been deprecated, we need to replace it.

$ bundle exec rake build:all
[DEPRECATED] `Bundler.with_clean_env` has been deprecated in
favor of `Bundler.with_unbundled_env`. If you instead want
the environment before bundler was originally loaded, use
`Bundler.with_original_env`

Docs Changes:
Not needed.

Release Note:
Not needed. (Not related to the behavior of the product)

    $ bundle exec rake build:all
    [DEPRECATED] `Bundler.with_clean_env` has been deprecated in
    favor of `Bundler.with_unbundled_env`. If you instead want
    the environment before bundler was originally loaded, use
    `Bundler.with_original_env`

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom added the enhancement Feature request or improve operations label Nov 27, 2023
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 7e9eba7 into fluent:master Dec 8, 2023
10 of 16 checks passed
@daipom daipom deleted the build-replace-deprecated-method branch December 13, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants