Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_tail: Fix warning log about overwriting entry with follow_inodes #4214

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jun 22, 2023

Which issue(s) this PR fixes:
None.

What this PR does / why we need it:
This fixes the following warning message:

... already exists. use latest one: deleted ...

Even when follow_inodes was enabled, this message was displayed based on the path.
This PR fixes it.

In addition, this PR slightly fixed this message when follow_inodes is enabled.

... (inode: ...) already exists. use latest one: deleted ...

Docs Changes:
No need because this fixes only the log message.

Release Note:
Same as the title.

@ashie ashie merged commit b71ab13 into fluent:master Jun 23, 2023
@ashie
Copy link
Member

ashie commented Jun 23, 2023

Thanks!

@ashie
Copy link
Member

ashie commented Jun 23, 2023

TODO: We need to apply it to v1.16 branch too.

@daipom daipom deleted the in_tail-fix-warning-overwriting-entry-with-follow_inodes branch June 23, 2023 08:11
@daipom
Copy link
Contributor Author

daipom commented Jun 23, 2023

Thanks for your review!

@daipom
Copy link
Contributor Author

daipom commented Jun 23, 2023

TODO: We need to apply it to v1.16 branch too.

OK! Shall I make the PR?

@daipom
Copy link
Contributor Author

daipom commented Jun 23, 2023

TODO: We need to apply it to v1.16 branch too.

OK! Shall I make the PR?

I made it:

@daipom daipom added this to the v1.16.2 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants