Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command option --quiet #4090

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Mar 12, 2023

Which issue(s) this PR fixes:
This fixes a bug related to #4037

What this PR does / why we need it:

Sorry, there was a bug in my following fix.

This PR fixes it.

Docs Changes:
Not needed.

Release Note:
Not needed.

Fix bug of:

* fluent#4064
* 8e9f46a

Signed-off-by: Daijiro Fukuda <[email protected]>
@ashie
Copy link
Member

ashie commented Mar 13, 2023

After #4064 is landed, CI on Windows have apparently failed more often and rarely succeeded.
Especially, tests after sub test case log_level by command line option often failed.
e.g.)

Although I don't think #4064 itself doesn't have problem, it seems that it triggers something.
When I remove the sub test case, CI becomes stable again:

@ashie
Copy link
Member

ashie commented Mar 13, 2023

CI on Windows are failed but it's not related with this PR as I described above.
So I merge this.

We need to investigate the CI failure later.

@ashie ashie merged commit 4e24866 into fluent:master Mar 13, 2023
@daipom daipom deleted the fix-command-option-quiet branch March 13, 2023 08:41
@daipom
Copy link
Contributor Author

daipom commented Mar 13, 2023

Thank for your review!

@ashie ashie added this to the v1.16.0 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants