test: use Fluent::Config::Element in test
#4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use `Fluent::Config::Element` instead of Hash. Signed-off-by: abetomo <[email protected]>
|
Whether we should merge this or not depends on the discussion in #4066 (comment) |
|
Sorry for the delay, yes I think so too. I'm considering #4066's goal. |
daipom
reviewed
Mar 6, 2023
Our conclusion in the discussion is #4066 (comment)
So we'll merge this. |
|
Thanks! |
daipom
reviewed
Mar 7, 2023
| @@ -135,7 +139,7 @@ def setup | |||
| end | |||
|
|
|||
| def test_format | |||
| @formatter.configure({}) | |||
| @formatter.configure(config_element()) | |||
There was a problem hiding this comment.
I guess this is the one we should use Fluent::Test::FormatterTestDriver for.
There was a problem hiding this comment.
Ah, sorry I've already merged this although you are right...
There was a problem hiding this comment.
No problem! I'm making another PR for this now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
( #4066 (comment) )
What this PR does / why we need it:
There is a case where
Hashis used in the test ofconfiguremethod.I fixed it because
configuremethod should useFluent::Config::Element.Docs Changes:
Release Note: