Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a test failure on ruby 3.2.0dev (2022-10-20) #3922

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

ashie
Copy link
Member

@ashie ashie commented Oct 20, 2022

Which issue(s) this PR fixes:
N/A

What this PR does / why we need it:
A test fails on latest Ruby-3.2dev.

The expected error massage pattern was

in_buggy.rb:5: syntax error, unexpected end-of-input, expecting

but the actual error message on Ruby 3.2 is

in_buggy.rb:5: syntax error, unexpected end-of-input (SyntaxError)

Docs Changes:
N/A

Release Note:
N/A

The expected error massage pattern was

```
in_buggy.rb:5: syntax error, unexpected end-of-input, expecting
```

but the actual error message on Ruby 3.2 is

```
in_buggy.rb:5: syntax error, unexpected end-of-input (SyntaxError)
```

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie force-pushed the fix-test-failure-on-ruby-3.2 branch from 8f5274c to 386ebf2 Compare October 20, 2022 06:42
@ashie ashie changed the title Fix a build failure on ruby 3.2.0dev (2022-10-20) Fix a test failure on ruby 3.2.0dev (2022-10-20) Oct 20, 2022
@ashie ashie marked this pull request as ready for review October 20, 2022 07:06
@ashie
Copy link
Member Author

ashie commented Oct 20, 2022

I've confirmed that the failed test has been fixed on CI.

@ashie ashie merged commit 5c41401 into master Oct 20, 2022
@ashie ashie deleted the fix-test-failure-on-ruby-3.2 branch October 20, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant