Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_in_tail: Show more information of test_unwatched_files_should_be_removed #3784

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

ashie
Copy link
Member

@ashie ashie commented Jun 14, 2022

It's unstable on macOS but hard to debug due to less information:

https://github.com/fluent/fluentd/runs/6872721774?check_suite_focus=true

2022-06-14T02:25:40.1951760Z Failure: test_unwatched_files_should_be_removed(TailInputTest::path)
2022-06-14T02:25:40.1968250Z /Users/runner/work/fluentd/fluentd/test/plugin/test_in_tail.rb:1615:in `test_unwatched_files_should_be_removed'
2022-06-14T02:25:40.1968820Z      1612:       waiting(20) { sleep 0.1 until Dir.glob("#{@tmp_dir}/*.txt").size == 0 } # Ensure file is deleted on Windows
2022-06-14T02:25:40.1969220Z      1613:       waiting(5) { sleep 0.1 until d.instance.instance_variable_get(:@tails).keys.size <= 0 }
2022-06-14T02:25:40.1969500Z      1614:
2022-06-14T02:25:40.1969770Z   => 1615:       assert_equal(0, d.instance.instance_variable_get(:@tails).keys.size)
2022-06-14T02:25:40.1970010Z      1616:
2022-06-14T02:25:40.1970200Z      1617:       d.instance_shutdown
2022-06-14T02:25:40.1970500Z      1618:     end
2022-06-14T02:25:40.1970720Z <0> expected but was
2022-06-14T02:25:40.1970910Z <1>

Signed-off-by: Takuro Ashie [email protected]

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

Docs Changes:

Release Note:

…_removed

It's unstable on macOS but hard to debug due to less information:

https://github.com/fluent/fluentd/runs/6872721774?check_suite_focus=true
```
2022-06-14T02:25:40.1951760Z Failure: test_unwatched_files_should_be_removed(TailInputTest::path)
2022-06-14T02:25:40.1968250Z /Users/runner/work/fluentd/fluentd/test/plugin/test_in_tail.rb:1615:in `test_unwatched_files_should_be_removed'
2022-06-14T02:25:40.1968820Z      1612:       waiting(20) { sleep 0.1 until Dir.glob("#{@tmp_dir}/*.txt").size == 0 } # Ensure file is deleted on Windows
2022-06-14T02:25:40.1969220Z      1613:       waiting(5) { sleep 0.1 until d.instance.instance_variable_get(:@Tails).keys.size <= 0 }
2022-06-14T02:25:40.1969500Z      1614:
2022-06-14T02:25:40.1969770Z   => 1615:       assert_equal(0, d.instance.instance_variable_get(:@Tails).keys.size)
2022-06-14T02:25:40.1970010Z      1616:
2022-06-14T02:25:40.1970200Z      1617:       d.instance_shutdown
2022-06-14T02:25:40.1970500Z      1618:     end
2022-06-14T02:25:40.1970720Z <0> expected but was
2022-06-14T02:25:40.1970910Z <1>
```

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie marked this pull request as ready for review June 14, 2022 06:50
@ashie
Copy link
Member Author

ashie commented Jun 14, 2022

Hmm, can't reproduce on CI in this pull request.
I merge this into master for further investigation.

@ashie ashie merged commit 1137d0f into master Jun 14, 2022
@ashie ashie deleted the output-more-info-of-unstable-test branch June 14, 2022 07:02
@ashie
Copy link
Member Author

ashie commented Jun 14, 2022

https://github.com/fluent/fluentd/runs/6875305374?check_suite_focus=true

2022-06-14T07:17:55.0456030Z Error: test_unwatched_files_should_be_removed(TailInputTest::path): SystemStackError: stack level too deep
2022-06-14T07:17:55.2289960Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:179:in `bind_call'
2022-06-14T07:17:55.2290470Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:179:in `object_address_group'
2022-06-14T07:17:55.2291380Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:241:in `pp_object'
2022-06-14T07:17:55.2292100Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:303:in `pretty_print'
2022-06-14T07:17:55.2292770Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:163:in `block in pp'
2022-06-14T07:17:55.2293490Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:253:in `block (2 levels) in group'
2022-06-14T07:17:55.2294200Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:280:in `nest'
2022-06-14T07:17:55.2294640Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:252:in `block in group'
2022-06-14T07:17:55.2294990Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:265:in `group_sub'
2022-06-14T07:17:55.2296120Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:251:in `group'
2022-06-14T07:17:55.2296450Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:163:in `pp'
2022-06-14T07:17:55.2296800Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:249:in `block (3 levels) in pp_object'
2022-06-14T07:17:55.2297180Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:253:in `block (2 levels) in group'
2022-06-14T07:17:55.2297540Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:280:in `nest'
2022-06-14T07:17:55.2297890Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:252:in `block in group'
2022-06-14T07:17:55.2298250Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:265:in `group_sub'
2022-06-14T07:17:55.2298590Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:251:in `group'
2022-06-14T07:17:55.2298980Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:247:in `block (2 levels) in pp_object'
2022-06-14T07:17:55.2299330Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:234:in `block in seplist'
...
2022-06-14T07:17:55.5053730Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:280:in `nest'
2022-06-14T07:17:55.5053890Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:252:in `block in group'
2022-06-14T07:17:55.5054060Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:265:in `group_sub'
2022-06-14T07:17:55.5054210Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/prettyprint.rb:251:in `group'
2022-06-14T07:17:55.5054350Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:163:in `pp'
2022-06-14T07:17:55.5054500Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:73:in `block in pp'
2022-06-14T07:17:55.5054660Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:120:in `guard_inspect_key'
2022-06-14T07:17:55.5054950Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:73:in `pp'
2022-06-14T07:17:55.5055170Z /Users/runner/work/fluentd/fluentd/test/plugin/test_in_tail.rb:1615:in `test_unwatched_files_should_be_removed'
2022-06-14T07:17:55.5055350Z      1612:       waiting(20) { sleep 0.1 until Dir.glob("#{@tmp_dir}/*.txt").size == 0 } # Ensure file is deleted on Windows
2022-06-14T07:17:55.5055520Z      1613:       waiting(5) { sleep 0.1 until d.instance.instance_variable_get(:@tails).keys.size <= 0 }
2022-06-14T07:17:55.5055590Z      1614: 
2022-06-14T07:17:55.5055670Z   => 1615:       assert_equal(
2022-06-14T07:17:55.5055730Z      1616:         {
2022-06-14T07:17:55.5055810Z      1617:           files: [],
2022-06-14T07:17:55.5055880Z      1618:           tails: {}

🤔

ashie added a commit that referenced this pull request Jun 14, 2022
…moved

Showing whole @Tails seems too heavy on CI environment:

```
2022-06-14T07:17:55.0456030Z Error: test_unwatched_files_should_be_removed(TailInputTest::path): SystemStackError: stack level too deep
2022-06-14T07:17:55.2289960Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:179:in `bind_call'
2022-06-14T07:17:55.2290470Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:179:in `object_address_group'
2022-06-14T07:17:55.2291380Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:241:in `pp_object'
...
2022-06-14T07:17:55.5055170Z /Users/runner/work/fluentd/fluentd/test/plugin/test_in_tail.rb:1615:in `test_unwatched_files_should_be_removed'
2022-06-14T07:17:55.5055350Z      1612:       waiting(20) { sleep 0.1 until Dir.glob("#{@tmp_dir}/*.txt").size == 0 } # Ensure file is deleted on Windows
2022-06-14T07:17:55.5055520Z      1613:       waiting(5) { sleep 0.1 until d.instance.instance_variable_get(:@Tails).keys.size <= 0 }
2022-06-14T07:17:55.5055590Z      1614:
2022-06-14T07:17:55.5055670Z   => 1615:       assert_equal(
2022-06-14T07:17:55.5055730Z      1616:         {
2022-06-14T07:17:55.5055810Z      1617:           files: [],
2022-06-14T07:17:55.5055880Z      1618:           tails: {}
```

Follow up for #3784

Signed-off-by: Takuro Ashie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant