in_exec: fix a file descriptor leaks #3634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every calling command from in_exec plugin, it causes a file descriptor leak. If interval is short enough or running Fluentd in long term, it will reaches the limit of file descriptor - "too many open files". In this commit, ensure to close IO object when it reaches EOF. Signed-off-by: Kentaro Hayashi <[email protected]>
ashie
reviewed
Feb 17, 2022
| @@ -95,6 +95,7 @@ def run(io) | |||
| else | |||
| @parser.parse(io.read, &method(:on_record)) | |||
| end | |||
| io.close if io.eof? | |||
There was a problem hiding this comment.
Generally speaking, resources should be closed by the one who opened it.
I'm not sure but closing it here might not be appropriate.
Open
|
Id just like to point out also here, that in #3627 I dont observe problems with in_exec itself, but only in combination of in_exec with out_exec. |
|
This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days |
|
Bump. |
|
I can't reproduce the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Follow up #3627
What this PR does / why we need it:
Every calling command from in_exec plugin, it causes
a file descriptor leak.
If interval is short enough or running Fluentd in long term,
it will reaches the limit of file descriptor - "too many open files".
In this commit, ensure to close IO object when it reaches EOF.
Docs Changes:
N/A
Release Note:
N/A