buffer: Use metrics plugin mechanism on a plugin base class #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <[email protected]>
…ot provided Signed-off-by: Hiroshi Hatake <[email protected]>
… variable Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
commented
Aug 6, 2021
| if type = (conf["@type"] || conf["type"]) | ||
| "#{type}.#{self.plugin_id}" | ||
| else | ||
| "#{self.class.to_s.split("::").last.downcase}.#{self.plugin_id}" |
There was a problem hiding this comment.
This is for out_file's default buffer plugin settings:
https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin/out_file.rb#L61-L65
ashie
approved these changes
Aug 6, 2021
cosmo0920
changed the title
This was referenced Oct 2, 2023
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
We should add more metrics plugin supported plugin base classes.
With these changes, our cmetrics metrics plugin also can work with Fluentd and Fluentd can handle native metrics to send prometheus format encodable metrics via fluent-plugin-metrics-cmetrics which binds cmetrics library.
Almost metrics plugin support will be handled in
#statisticsmethods. So, it won't be caused significant performance degradation.Docs Changes:
Needed.
Release Note:
Same as title.