Merge v1.12.4 into master #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous Fluentd v1.11.x implementation uses path based tailing keys. We wouldn't rewrite tailing mechanism entirely. And also we're implicitly assuming path based equality for TargetInfo in tailing logic. We should handle TargetInfo with path based equality instead of path and inode based equality. Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
…sub_test_case Signed-off-by: Hiroshi Hatake <[email protected]>
in_tail: position_file: Define path based equalities on TargetInfo (for v1.12)
Signed-off-by: Takuro Ashie <[email protected]>
|
Review is already done at #3391. |
|
Let's |
after CIs are finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #3391, #3365
What this PR does / why we need it:
Merge changes in v1.12.4 into master
Docs Changes:
none
Release Note:
none