Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Add macOS and remove .travis.yml #3290

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

ashie
Copy link
Member

@ashie ashie commented Mar 9, 2021

Which issue(s) this PR fixes:
none

What this PR does / why we need it:
We are migrating CI from TravisCI to GitHub Actions.
This PR add macOS workflow on GitHub Actions and remove .travis.yml to complete this work.
Other minor platforms are dropped by this PR because GitHub Actions doesn't support them:

  • ppc64le
  • s390x

Docs Changes:
none

Release Note:
none

Signed-off-by: Takuro Ashie <[email protected]>
We've completely moved to GitHub Actions.
CI for Some minor platforms has been dropped.

* ppc64le
* s390x

Signed-off-by: Takuro Ashie <[email protected]>
Fix the following failure:

Failure: test: can execute external command just once, and can terminate it forcedly when shutdown/terminate even if it ignore SIGTERM(ChildProcessTest):
        assert { lines2 > lines1 }
                 |      | |
                 |      | 0
                 |      false
                 0
/Users/runner/work/fluentd/fluentd/test/plugin_helper/test_child_process.rb:301:in `block (2 levels) in <class:ChildProcessTest>'
     298:       @d.shutdown
     299:       sleep TEST_WAIT_INTERVAL_FOR_LOOP
     300:       lines2 = ary.size
  => 301:       assert { lines2 > lines1 }
     302:       @d.close
     303:
     304:       assert_nil((Process.waitpid(pid, Process::WNOHANG) rescue nil))

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie requested a review from cosmo0920 March 9, 2021 15:26
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd confirmed that always failing testcase on macOS should be fixed. 💪

@cosmo0920 cosmo0920 merged commit 4d03e73 into fluent:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants