-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise feat ignore_if_prev_successes to copy plugin #3287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiago Goddard <[email protected]>
Signed-off-by: Tiago Goddard <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
revise-feat-ignore-prev-success
branch
from
March 8, 2021 08:02
762ad71
to
a148ec0
Compare
kenhys
requested changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some requests to make it user-friendly.
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
revise-feat-ignore-prev-success
branch
from
March 8, 2021 09:41
bdbaef2
to
5afb9fa
Compare
directive Signed-off-by: Hiroshi Hatake <[email protected]>
ignore_if_prev_success is not specified Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
revise-feat-ignore-prev-success
branch
from
March 9, 2021 00:06
5afb9fa
to
3041046
Compare
kenhys
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Revised #3190
In this revised version, I added a testcase fix for #3190 (comment).
What this PR does / why we need it:
According to #3130:
Docs Changes:
Release Note:
Same as title.