Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise feat ignore_if_prev_successes to copy plugin #3287

Merged
merged 6 commits into from
Mar 9, 2021

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Mar 8, 2021

Which issue(s) this PR fixes:
Revised #3190

In this revised version, I added a testcase fix for #3190 (comment).

What this PR does / why we need it:

According to #3130:

This PR makes a change in the Copy Output plugin so you can inform the fluentd to ignore said copy if the previous output succeeded.

This enables having multiple nested outputs as backup of each other by doing:

   <store ignore_error>
     @type test
     name c0
   </store>
   <store ignore_if_prev_success ignore_error>
     @type test
     name c1
   </store>
   <store ignore_if_prev_success>
     @type test
     name c2
   </store>

Docs Changes:

Adding the defined ignore_if_prev_successes attribute to the tag makes the copy plugin ignore said store if the previous store succeed in pushing the output.

Release Note:

Same as title.

Tiago Goddard added 2 commits March 8, 2021 16:54
Signed-off-by: Tiago Goddard <[email protected]>
@cosmo0920 cosmo0920 requested review from repeatedly and ashie March 8, 2021 07:59
@cosmo0920 cosmo0920 force-pushed the revise-feat-ignore-prev-success branch from 762ad71 to a148ec0 Compare March 8, 2021 08:02
@cosmo0920 cosmo0920 requested a review from kenhys March 8, 2021 08:23
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some requests to make it user-friendly.

test/plugin/test_out_copy.rb Show resolved Hide resolved
lib/fluent/plugin/out_copy.rb Show resolved Hide resolved
Signed-off-by: Hiroshi Hatake <[email protected]>
@cosmo0920 cosmo0920 force-pushed the revise-feat-ignore-prev-success branch from bdbaef2 to 5afb9fa Compare March 8, 2021 09:41
ignore_if_prev_success is not specified

Signed-off-by: Hiroshi Hatake <[email protected]>
@cosmo0920 cosmo0920 force-pushed the revise-feat-ignore-prev-success branch from 5afb9fa to 3041046 Compare March 9, 2021 00:06
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosmo0920 cosmo0920 merged commit dcc47e8 into master Mar 9, 2021
@cosmo0920 cosmo0920 deleted the revise-feat-ignore-prev-success branch March 9, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants