Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak GitHub Actions and Remove AppVeyor #3281

Merged
merged 9 commits into from
Mar 5, 2021

Conversation

ashie
Copy link
Member

@ashie ashie commented Mar 5, 2021

Which issue(s) this PR fixes:
none

What this PR does / why we need it:
We need to tune CI because recently it always fail.
This PR is an intermediate result of tuning it:

  • CI on Linux will be moved from TravisCI to GitHub Actions
    • .travis.yml isn't removed yet because macOS isn't migrated yet.
    • ppc64le and s390x will be completely removed (not included in this PR yet).
  • Windows CI has been moved to GitHub Actions, AppVeyor will be removed
    • Dozens of in_tail tests are still failed, but it's same with AppVeyor. I'm now investigating it.
  • Disable some failed tests on Ruby 3.0
    • We need to fix RR to re-enable them
  • We'll continue to use Drone for Arm architecture.

Docs Changes:
none

Release Note:
none

ashie added 9 commits March 4, 2021 09:59
Detailed information for succeeded tests shouldn't be shown to highlight
failed tests.

Signed-off-by: Takuro Ashie <[email protected]>
It doesn't support kwargs of Ruby 3 yet.

https://github.com/rr/rr/blob/223378ae65175a22aeb5254d7719a56d02f0ba76/lib/rr/injections/double_injection.rb#L149

Above code should pass not only *args but also **kwargs to an original
method.

Signed-off-by: Takuro Ashie <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]>
It seems that GitHub Actions is enough instead, it's much faster than
AppVeyor because max number of parallel workers is lager than it.
Although dozens of in_tail tests are still failed, it's same with
AppVeyor.

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie requested a review from cosmo0920 March 5, 2021 04:23
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Yeah, key words arguments failures on Ruby 3.0 should be fixed later.

.github/workflows/linux-test.yaml Show resolved Hide resolved
@ashie ashie merged commit 3b88465 into fluent:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants