Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make better use of freeze #3170

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Make better use of freeze #3170

merged 1 commit into from
Nov 16, 2020

Conversation

repeatedly
Copy link
Member

Signed-off-by: Masahiro Nakagawa [email protected]

Which issue(s) this PR fixes:
Follow up: #3152

What this PR does / why we need it:

  • Add freeze to string parameter
  • Remove duplicated freeze

Docs Changes:
No need

Release Note:
Add this to Refactoring code

@repeatedly
Make better use of freeze
fa347b0 
Signed-off-by: Masahiro Nakagawa <[email protected]>
@repeatedly repeatedly added the enhancement Feature request or improve operations label Nov 16, 2020
@repeatedly repeatedly requested a review from cosmo0920 November 16, 2020 06:51
@repeatedly repeatedly self-assigned this Nov 16, 2020
cosmo0920
cosmo0920 approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. 👍

@repeatedly repeatedly merged commit 5e036cf into master Nov 16, 2020
@repeatedly repeatedly deleted the better-freeze branch November 16, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees

@repeatedly repeatedly

Labels
enhancement Feature request or improve operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @cosmo0920