make chunk key configurable from plugins #314
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A key name of chunk can be specified in 4th argument of
BufferedOutput#emit
in BufferedOutput class, but no one use this argument and no hook point for setting the value. It is good to be able to configure it from plugins likeformat
.If this feature is available, plugins can determine how to handle chunks depending on the chunk key. For instance, destination server is determined by the tag. I know the example can be achieved by using fluent-plugin-forest. Though I think it is easy to provide a plugin with built-in features like fluent-plugin-hash-forward.
Actually I want to set the key name from log data, but it is inefficient to call
chunk_key
for each message just likeformat
. For that purpose, I think Mixin approach is better and allowformat
to also return a key name of chunk. How do you think about it?