Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor buffer code #3118

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Refactor buffer code #3118

merged 3 commits into from
Sep 1, 2020

Conversation

repeatedly
Copy link
Member

Which issue(s) this PR fixes:
Follow up: #3018

What this PR does / why we need it:

  • Skip timekeys calculation when no time chunk key. This is for the performance.
  • Improve/refactor buffer code

Docs Changes:
No need

Release Note:
Listed in Refactoring code section.

@repeatedly repeatedly added the enhancement Feature request or improve operations label Aug 31, 2020
@repeatedly repeatedly requested a review from cosmo0920 August 31, 2020 11:13
@repeatedly repeatedly self-assigned this Aug 31, 2020
cosmo0920
cosmo0920 approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@repeatedly repeatedly merged commit b5f4a6d into master Sep 1, 2020
@cosmo0920 cosmo0920 deleted the refactor-buffer-code branch September 1, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees

@repeatedly repeatedly

Labels
enhancement Feature request or improve operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @cosmo0920