Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'#match?' is better than '#match' #2966

Merged
merged 1 commit into from
Apr 21, 2020
Merged

'#match?' is better than '#match' #2966

merged 1 commit into from
Apr 21, 2020

Conversation

repeatedly
Copy link
Member

@repeatedly repeatedly commented Apr 21, 2020 •
edited
Loading

Signed-off-by: Masahiro Nakagawa [email protected]

Which issue(s) this PR fixes:
No issue.

What this PR does / why we need it:
fluentd dropped ruby 2.3 or earlier, so we can use match? for faster matching.

Docs Changes:
No need

Release Note:
Improve regexp match with match? method.

@repeatedly
'#match?' is better than '#match'
205b937 
Signed-off-by: Masahiro Nakagawa <[email protected]>
@repeatedly repeatedly added the enhancement Feature request or improve operations label Apr 21, 2020
@repeatedly repeatedly requested a review from ganmacs April 21, 2020 06:43
@repeatedly repeatedly self-assigned this Apr 21, 2020
@repeatedly repeatedly merged commit fddde2f into master Apr 21, 2020
@repeatedly repeatedly deleted the use-lightweight-match branch April 21, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganmacs ganmacs ganmacs approved these changes

Assignees

@repeatedly repeatedly

Labels
enhancement Feature request or improve operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @ganmacs